PlexSheep/pt
PlexSheep
/
pt
generated from PlexSheep/baserepo
1
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases 23 Wiki Activity

feat/bintols/join-array #80

Merged
PlexSheep merged 5 commits from feat/bintols/join-array into devel 2024-05-13 15:16:19 +02:00
Conversation 0 Commits 5 Files Changed 3 +106
PlexSheep commented 2024-05-13 14:58:36 +02:00
Owner
Copy Link
No description provided.
PlexSheep added 2 commits 2024-05-13 14:58:36 +02:00
cargo devel CI / cargo CI (push) Successful in 1m58s Details
a1c5725c55 add tests for the join module #79
forgejo-actions added 1 commit 2024-05-13 14:59:51 +02:00
PlexSheep reviewed 2024-05-13 15:00:35 +02:00
members/libpt-bintols/src/join.rs
@ -0,0 +40,4 @@
for (i, e) in parts.iter().rev().enumerate() {
ri += (*e as u128) * 256u128.pow(i as u32);
}
Ok(ri.to_string().parse().unwrap())
PlexSheep commented 2024-05-13 15:00:17 +02:00
Author
Owner
Copy Link

Don't rely on u128 for this function, use pure generics if possible. Don't convert to string and parse back to get a T

Don't rely on u128 for this function, use pure generics if possible. Don't convert to string and parse back to get a T
PlexSheep added 1 commit 2024-05-13 15:00:46 +02:00
cargo devel CI / cargo CI (push) Successful in 1m47s Details
b9f55d1613 Merge branch 'devel' into feat/bintols/join-array
PlexSheep added 1 commit 2024-05-13 15:13:37 +02:00
PlexSheep changed title from WIP: feat/bintols/join-array to feat/bintols/join-array 2024-05-13 15:13:52 +02:00
PlexSheep merged commit 8f75925ec3 into devel 2024-05-13 15:16:19 +02:00
PlexSheep deleted branch feat/bintols/join-array 2024-05-13 15:16:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PlexSheep/pt#80
No description provided.
Delete Branch "feat/bintols/join-array"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?