PlexSheep
/
numf
generated from PlexSheep/rs-base
1
1
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

WIP: Guess the format of numbers #24

Draft
PlexSheep wants to merge 0 commits from feat/guess-format into devel
pull from: feat/guess-format
merge into: PlexSheep:devel
Conversation 2 Commits - Files Changed -
PlexSheep commented 2024-05-23 13:35:03 +02:00
Owner
Copy Link

it should be possible to input hex numbers, bin numbers and so on.

Consider adding a --guess flag (or --no-guess) to disable/enable guessing.

Guessing should not be the default, I suppose, as someone might want to input 0d10 but have it be interpreted as 0b10.

Refs: #20

  • Split the functionalities of the numf_parser
  • add another parser that allows setting a guess: bool parameter
  • have it guess the format with all supported formats
  • test guessing of formats
it should be possible to input hex numbers, bin numbers and so on. Consider adding a --guess flag (or `--no-guess`) to disable/enable guessing. Guessing should not be the default, I suppose, as someone might want to input `0d10` but have it be interpreted as `0b10`. Refs: #20 - [ ] Split the functionalities of the `numf_parser` - [ ] add another parser that allows setting a `guess: bool` parameter - [ ] have it guess the format with all supported formats - [ ] test guessing of formats
PlexSheep added the
Kind/Feature
Priority
Medium
Reviewed
Confirmed
 labels 2024-05-23 13:35:03 +02:00
PlexSheep self-assigned this 2024-05-23 13:35:03 +02:00
PlexSheep commented 2024-05-23 13:48:01 +02:00
Author
Owner
Copy Link

we need to specify a parser with a single parameter with clap derive to accept numbers with the cli. We could probably do manual parsing, but that sucks and I don't want to do it. We could implement guessing automatically, but then the user couldn't choose, which is something I don't want too.

This is more difficult than expected.

we need to specify a parser with a single parameter with clap derive to accept numbers with the cli. We could probably do manual parsing, but that sucks and I don't want to do it. We could implement guessing automatically, but then the user couldn't choose, which is something I don't want too. This is more difficult than expected.
PlexSheep commented 2024-05-23 13:53:22 +02:00
Author
Owner
Copy Link

We really only have these options:

  1. Don't use clap to parse our stuff and parse the numbers manually
  2. Only guess-parse the stdin
We really only have these options: 1. Don't use clap to parse our stuff and parse the numbers manually 2. Only guess-parse the stdin
All checks were successful
cargo devel CI / cargo CI (push) Successful in 1m18s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feat/guess-format devel
git pull origin feat/guess-format

Step 2:

Merge the changes and update on Forgejo.
git checkout devel
git merge --no-ff feat/guess-format
git push origin devel
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
PlexSheep
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PlexSheep/numf#24
No description provided.
Delete Branch "feat/guess-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?